-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/e
: Set RZ_REGEX_MULTILINE
for ^
and $
#4868
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazarmy
requested review from
wargio,
thestr4ng3r,
ret2libc and
Rot127
as code owners
January 29, 2025 05:22
wargio
approved these changes
Jan 29, 2025
Rot127
requested changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but please document this in the /e
command. It is not obvious to the user and I might forget it when I refactor it later this week.
Rot127
approved these changes
Jan 29, 2025
Rot127
requested changes
Jan 29, 2025
Co-authored-by: Rot127 <[email protected]>
Rot127
approved these changes
Jan 29, 2025
tushar3q34
pushed a commit
to tushar3q34/rizin
that referenced
this pull request
Feb 2, 2025
* `/e`: Set `RZ_REGEX_MULTILINE` for `^` and `$` * Add note in `/e` help for `^` and `$` Co-authored-by: Rot127 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
RZ_API
function and struct this PR changes.RZ_API
).Detailed description
This pr sets
RZ_REGEX_MULTILINE
for the/e
regex search so that^
and$
can match the beginning and end respectively of a C string. For^
, there is probably the assumption that the string is at the beginning of the searched area or has a\0
before it.Test plan
All builds are green.
Closing issues
...